Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface Pro 5 wakes up on lid closing (but not opening) #2

Closed
ceever opened this issue Feb 18, 2023 · 1 comment
Closed

Surface Pro 5 wakes up on lid closing (but not opening) #2

ceever opened this issue Feb 18, 2023 · 1 comment

Comments

@ceever
Copy link

ceever commented Feb 18, 2023

Issue
Whenever I turn my Surface into suspend mode, it will wake up on lid (aka Typecover) closing, but not on lid opening.

This way unfortunately I can never put my Surface into Suspend and then close the lid. Therefore currently, I am running Suspend with a 5 seconds delay, so the lid can be closed before Suspend is executed. When the lid is closed before Suspend is initiated, the Surface remains in Suspend afterwards.

However, the Suspend mode is not interrupted on lid opening either, even though the Typecover (aka lid) starts illuminating the keys after a few seconds delay. No key will wake the device, only the Power Button will do this.

My current workaround is to deactivate the Surface GPE: "sudo modprobe -r surface_gpe" ... after which I can close and open the lid without affecting the Suspend mode of device.

Expected behaviour
Surface does not wakeup at all on closing the lid/Typecover.

System information
Machine: Surface Pro 5 (2017)
Kernel: 5.19.13-surface
OS: Ubuntu / LXQt / 20.04

@qzed
Copy link
Member

qzed commented Feb 18, 2023

The surface-gpe module doesn't do anything other than marking the interrupts as wakeup capable and we can't differentiate between closing and opening just by this (this needs to be done in the lid driver itself). It's possible that we may need to modify surface-gpe to essentially hook the GPE up to the lid device (so that the lid knows that the GPE is the wakeup source), but I'm not sure about that yet. So let's handle this at linux-surface/linux-surface#1060 for now.

@qzed qzed closed this as completed Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants