Documentation: teaching: labs: Clarify role of kill_*_super functions #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Baronescu <[email protected]>
* update links to point to 4.15.7 kernel API * use c constructs (:c:type:``, :c:macro:`` etc) to highlight structures, macros etc Signed-off-by: Anda Nicolae <[email protected]>
* removed links to lxr kernel API * used :c:type:``, :c:data:``, :c:func:``, etc in all lab, when appropriate * reformulated documentation when needed * added missing list evolution image Signed-off-by: Anda Nicolae <[email protected]>
Signed-off-by: Daniel Baluta <[email protected]>
Since the exchange value in atomic_cmpxchg is set at 1, atomic_inc will not reset it, and so, the resource will be busy at any second call. atomic_dec, or simply, atomic_set to 0, as implied in the TODO.
Signed-off-by: Octavian Purdila <[email protected]>
Signed-off-by: Octavian Purdila <[email protected]>
Signed-off-by: Robert Baronescu <[email protected]>
Signed-off-by: Anda Nicolae <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
…ignment Signed-off-by: Razvan Deaconescu <[email protected]>
…-list Signed-off-by: Razvan Deaconescu <[email protected]>
… assigments/ subfolder Signed-off-by: Razvan Deaconescu <[email protected]>
to avoid confusion with global variable name
Signed-off-by: Daniel Baluta <[email protected]>
Signed-off-by: Daniel Baluta <[email protected]>
Signed-off-by: Daniel Baluta <[email protected]>
tools: assignments: 2-uart: Apply checkpatch.pl Signed-off-by: Alexandra Sandulescu <[email protected]>
Signed-off-by: Alexandra Sandulescu <[email protected]>
Signed-off-by: Alexandra Sandulescu <[email protected]>
Signed-off-by: Alexandra Sandulescu <[email protected]>
Update the RCU diagram so that B to C link is showed as preserved during the removal phase. Signed-off-by: Octavian Purdila <[email protected]>
Signed-off-by: Valentin Ghita [email protected]
Remove the so2_ prefix which has no relevance currently and simplify the example to make it easier to demonstrate in the debugging lecture. Signed-off-by: Octavian Purdila <[email protected]>
Remove a few headers we don't use and the so2 prefix. More importantly remove the schedule_timeout statement as it is not needed for lockdep to detect the issue and add debug prints to show that. Signed-off-by: Octavian Purdila <[email protected]>
Remove the while (1) block as it is not necessary for lockdep to detect the issue. Also, use new APIs to make the code more compact and remove the so2 prefix. Signed-off-by: Octavian Purdila <[email protected]>
Enable kmemleak in the kernel config and update qemu to start with 256MB as otherwise we get an early memory allocation error. Signed-off-by: Octavian Purdila <[email protected]>
This is just a workaround, see the thread [1] on the netdev mailing list for the discussion around this issue. But it allows us to avoid the initial lockdep warning on boot that disables futher lockdep checks. [1] https://www.spinics.net/lists/netdev/msg529595.html Signed-off-by: Octavian Purdila <[email protected]>
Update the SLUB debugging, kmemleak and lockdep checker sections with more information a few examples. Signed-off-by: Octavian Purdila <[email protected]>
Signed-off-by: Octavian Purdila <[email protected]>
As soon as the lock is unlocked in task_info_find_pid, the caller cannot be sure if the pointer that is returned is valid. As long as the returned pointer is used, the lock must be held. In the case of task_info_add_to_list, the lock that must be held is a writer lock, in case of a reader lock other readers could read an inconsistent state of the struct task_info.
Starting from kernel version 4.10, `bio_set_op_attrs` is marked as
obsolete. The recommended action is to directly assign the `bio_opf`
field of the `struct bio`.
Code extract from `/include/linux/blk_types.h` (v4.19):
```c
/* obsolete, don't use in new code */
static inline void bio_set_op_attrs(struct bio *bio, unsigned op,
unsigned op_flags)
{
bio->bi_opf = op | op_flags;
}
```
Signed-off-by: Horia Ion <[email protected]>
`minfs_write_inode` should fill the disk inode with the aquired `uid` and `gid` from the inode, not the other way round. Please check the `minix` solution below: https://elixir.bootlin.com/linux/latest/source/fs/minix/inode.c#L557
This fixes errors during the "Install native dependencies" step for building documentation. Signed-off-by: Octavian Purdila <[email protected]>
For the `makedev` macro in newer versions of Glibc (since v2.28) we need to directly include <sys/sysmacros.h>, because that is no longer included by <sys/types.h>. Fix by including the correct header. Signed-off-by: Paul-Stelian Olaru <[email protected]>
Up until this commit only core-image-miminal-* Yocto image files were ignored. Others, such as core-image-sato-* Yocto image files were not. This commit fixes that, will al Yocto image files being ignored. Signed-off-by: Razvan Deaconescu <[email protected]>
Signed-off-by: Sergiu Weisz <[email protected]>
Signed-off-by: Sergiu Weisz <[email protected]>
For 5-pitix assignment there is no info about score or the number of test passed (at least a counter). Simple searching for "failed" in output is error prone (and painfully hard for the average Joe). A simple solution is to add a test_ok var to count the number of passed test. Better solutions exist, but keep it simple stupid as fellow student only care about the number of tests passed to know the homework is okay.
- Change TODO numbering to match code template - Fix and improve testing instructions
… ditaa diagrams Signed-off-by: Octavian Purdila <[email protected]>
Signed-off-by: Razvan Deaconescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the role and use case for
kill_litter_superandkill_anon_superfunctions.