fix: [M3-8451] - List events in event landing page in chronological order #11339
+110
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-akamai
changed the title
harsh-akamai
commented
Nov 28, 2024
There was a problem hiding this comment.
I've extended the Event interface to include completionTime for an event and moved the getEventTimeStamp() to the sorting util function.
Cloud Manager UI test results🎉 455 passing tests on test run #3 ↗︎
|
harsh-akamai
requested review from
hana-akamai and
carrillo-erik
and removed request for
a team
hana-akamai
reviewed
Dec 10, 2024
|
|
||
| export interface completionEvent extends Event { |
There was a problem hiding this comment.
Nit: I think completedEvent sounds a bit better than completionEvent
Comment on lines
+140
to
+150
| const dates = tableBodyRows.map((row) => { | ||
| const cells = within(row).getAllByRole('cell'); | ||
| return cells[3].textContent || ''; | ||
| }); | ||
|
|
||
| // util function to check if the dates are in descending order | ||
| const areDatesSorted = dates.every( | ||
| (date, i, arr) => i === 0 || new Date(arr[i - 1]) >= new Date(date) | ||
| ); | ||
|
|
||
| expect(areDatesSorted).toBe(true); |
There was a problem hiding this comment.
Can we add a test-id to the Absolute Date table cell and grab the dates that way instead of grabbing the cell at index 3?
We can also just hardcode the date string; I think the test is clearer this way:
const mockEvent1 = eventFactory.build({
...
created: '2024-12-10T16:29:52.973-05:00',
...
});
const mockEvent2 = eventFactory.build({
...
created: '2024-12-10T16:28:52.974-05:00',
...
});
expect(dates).toStrictEqual(['2024-12-11 05:30', '2024-12-11 05:28']);To test the sorting function, we can add a separate unit test for the sortEventsChronologically function in the utils test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Currently not all events in the landing page are sorted in a chronological order. This seems to be because we adjust the event creation date to accommodate the duration for a
finishedorfailedevent.Changes 🔄
Preview 📷
How to test 🧪
Reproduction steps
This can be most easily reproduced when performing some action that triggers multiple events to happen in a short timeframe.
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅