Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8912] - Create support ticket for buckets created through legacy flow #11300

Conversation

harsh-akamai
Copy link
Contributor

@harsh-akamai harsh-akamai commented Nov 21, 2024

Description 📝

This PR addresses 2 errors during the ObjectStorage Support Ticket creation flow:

  • If an account has multiple buckets in the same region/cluster, the Create Support Ticket workflow reads only the first bucket.
  • An error occurs when attempting to create a Support Ticket for a bucket that was created using the legacy flow (buckets created through clusters).

Changes 🔄

  • Added Support for buckets created through the legacy flow
  • Fixed the create flow for accounts that have multiple buckets in the same region/cluster

Target release date 🗓️

12/10

Preview 📷

Before
image
Screen.Recording.2024-11-21.at.6.28.41.PM.mov

How to test 🧪

Prerequisites

  • Turn on legacy flow for Object Storage (Check internal ticket for customer tags)
  • Test this in the dev environment to avoid bothering Customer Support with real tickets

Reproduction steps

  • Creating an Object Storage Support ticket from an account that has multiple buckets in the same region/cluster picks only the first bucket as shown in preview video
  • Submitting an Object Storage Support ticket form an account that has legacy flow present throws an error as shown in the preview

Verification steps

  • Ensure an Object Storage Support ticket can be created in both scenarios pointed out

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@harsh-akamai harsh-akamai self-assigned this Nov 21, 2024
@harsh-akamai harsh-akamai marked this pull request as ready for review November 21, 2024 13:40
@harsh-akamai harsh-akamai requested a review from a team as a code owner November 21, 2024 13:40
@harsh-akamai harsh-akamai requested review from dwiley-akamai and pmakode-akamai and removed request for a team November 21, 2024 13:40
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

✅ Now able to select different buckets from dropdown list
✅ Now able to create an ObjectStorage support ticket without any field errors

❗️Just need a changeset for this one

@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 28, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, let's get a changeset added for manager with a category of Fixed.

@harsh-akamai harsh-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 4, 2024
…912-fix-support-ticket-creation-for-obj-storage
Copy link

github-actions bot commented Dec 5, 2024

Coverage Report:
Base Coverage: 86.85%
Current Coverage: 86.85%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 466 passing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing466 Passing2 Skipped104m 16s

@harsh-akamai harsh-akamai merged commit 3d62d31 into linode:develop Dec 6, 2024
23 checks passed
@harsh-akamai harsh-akamai deleted the M3-8912-fix-support-ticket-creation-for-obj-storage branch December 6, 2024 06:38
Copy link

cypress bot commented Dec 6, 2024

Cloud Manager E2E    Run #6928

Run Properties:  status check passed Passed #6928  •  git commit 3d62d317db: fix: [M3-8912] - Create support ticket for buckets created through legacy flow (...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6928
Run duration 27m 43s
Commit git commit 3d62d317db: fix: [M3-8912] - Create support ticket for buckets created through legacy flow (...
Committer Harsh Shankar Rao
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants