fix: [UIE-8259] dbaas summary blank read-only host should be N/A

linode · Nov 15, 2024 · 2bba2be · 2bba2be
1 parent 1d0051e
commit 2bba2be
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 7 deletions.
diff --git a/packages/manager/.changeset/pr-11265-fixed-1731619488790.md b/packages/manager/.changeset/pr-11265-fixed-1731619488790.md
@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+dbaas summary read-only host field is blank ([#11265](https://github.com/linode/manager/pull/11265))
diff --git a/...atures/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.test.tsx b/...atures/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.test.tsx
@@ -77,6 +77,27 @@ describe('DatabaseSummaryConnectionDetails', () => {
     });
   });
 
+  it('should display N/A for default DB with blank read-only Host field', async () => {
+    const database = databaseFactory.build({
+      engine: POSTGRESQL,
+      hosts: {
+        primary: DEFAULT_PRIMARY,
+        secondary: undefined,
+        standby: undefined,
+      },
+      id: 99,
+      platform: 'rdbms-default',
+      port: 22496,
+      ssl_connection: true,
+    });
+
+    const { queryAllByText } = renderWithTheme(
+      <DatabaseSummaryConnectionDetails database={database} />
+    );
+
+    expect(queryAllByText('N/A')).toHaveLength(1);
+  });
+
   it('should display correctly for legacy db', async () => {
     queryMocks.useDatabaseCredentialsQuery.mockReturnValue({
       data: {

diff --git a/...rc/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.tsx b/...rc/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryConnectionDetails.tsx
@@ -116,16 +116,14 @@ export const DatabaseSummaryConnectionDetails = (props: Props) => {
     database?.hosts?.standby ?? database?.hosts?.secondary ?? '';
 
   const readOnlyHost = () => {
-    const defaultValue = isLegacy ? '-' : 'not available';
-    const value = readOnlyHostValue ?? defaultValue;
+    const defaultValue = isLegacy ? '-' : 'N/A';
+    const value = readOnlyHostValue ? readOnlyHostValue : defaultValue;
+    const displayCopyTooltip = value !== '-' && value !== 'N/A';
     return (
       <>
         {value}
-        {value && (
-          <CopyTooltip
-            className={classes.inlineCopyToolTip}
-            text={readOnlyHostValue}
-          />
+        {value && displayCopyTooltip && (
+          <CopyTooltip className={classes.inlineCopyToolTip} text={value} />
         )}
         {isLegacy && (
           <TooltipIcon