Add percentage functionality #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah, I didn't write tests... yet. Let me know if you want this to be merged into master and I will write tests for it. |
|
@klautcomputing Thanks for your work. I would be happy to merge this to |
|
You are welcome. I will do so either today or tomorrow. |
|
this is not needed anymore see #47 for a better approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my idea for: #20
Changes:
chaoskubenow supports the--percentageflag--percentagetakes an integer as option--percentage 10ten percent of the current pods will be killed.chaoskubechecks after every pod termination how many candidates there are and then calculates how long it will have to wait until it has to terminate another pod so that it reachesxpercent per hour. This will handle more services getting deploy or old ones removed without having to restartchaoskubechaoskubeneeds to be invoked with either--intervalor--percentage, there is no default anymoreLet me know what you think.
I removed
log.Debugf("Sleeping for %s...", interval)because we are technically not sleeping anymore. And I only inform about interval updates. Feel free to ask me to bring that functionality back if you want it to stay.