Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to read test options from a config file #3

Closed
mayankshah1607 opened this issue Jun 3, 2020 · 1 comment
Closed

Comments

@mayankshah1607
Copy link
Contributor

What would you like to add?

Once linkerd/linkerd2#4532 gets merged, it would be great to have the tests read a config, ideally a yaml file that defines configuration options for things like ingress controllers, allow tests, disable tests, verbose, etc.

How should this be done?

In case of Sonobuoy, we may want the users to create a configMap object in the sonobuoy namespace to hold this yaml config file. We then mount it using the podSpec property on the Sonobuoy plugin file. With the help of K8s client-go, the tests may then read the config first and run tests accordingly.

If users wish to plug in the config file outside of Sonobuoy, i.e, running the tests locally, an optional flag --config-path may be used. The tests then pick-up the config file from the value of the flag if no configMap is found. In the situation where users may want to run the tests locally inside the Docker image provided, an additional volume may be mounted onto the container along with the flag.

@mayankshah1607
Copy link
Contributor Author

Closed via #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant