This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
GH-111: refreshBubblePosition updates all known callouts #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…louts. Also fixes error in getCurrStep() when called when no tour is in progress.
timlindvall
changed the title
|
Looks good to me. Will pull this in by EOD today if there are no other comments. |
kate2753
added a commit
that referenced
this pull request
Dec 10, 2014
GH-111: refreshBubblePosition updates all known callouts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to hopscotch.refreshBubblePosition() should also update all callouts. Because this call requires current step information, we additionally cache the opts used to create the HopscotchBubble when we add a new callout. Also fixes error in getCurrStep() when called when no tour is in progress.
Resolves issue #111.