GreyKite 0.3.0 Library Issue

[PbSapConnector]

Hello,

We are experiencing critical issues when executing Greykite 0.3.0 in a project in production because the "holidays_ext.py" file from this very same 0.3.0 version has been recently altered.

Here, we attach a screenshot of the last lines of the "holidays_ext.py" file that we had locally installed since more than 10 months:

However, when the local environment of this project is replicated in another machine and downloading specifically Greykite 0.3.0 version, the "holidays_ext.py" file is different:

This addition of new lines makes the code break every time it is executed with the following logs of errors (irrespective of it is executed in an Azure server or locally):

When the "holidays_ext.py" file is replaced by the previous one existing in the machine where Greykite 0.3.0 was installed in its respective directory (".conda\envs<ENVIRONMENT NAME> \Lib\site-packages\holidays_ext"), everything works perfectly.

Could you please solve this issue and replace the "holidays_ext.py" t

hat is downloaded when installing greykite (pip install greykite=="0.3.0") by the previous one, so that this version of the library that was released more than 1 year ago is kept exactly as it was released?

This is a critical issue, so let us know as soon as possible.

Thank you.

Github_issue.docx

[sayanpatra]

@PbSapConnector Seems like you are having the same issue mentioned in this thread. Follow the suggestions there and let us know if that works.

[PbSapConnector]

Dear @sayanpatra,

The solution provided doesn't meet our needs since we are not able to apply it into azure machine learning project.
Our problem occurs when we try to run the code from an azure machine learning studio's experiment.
Azure ML uses automatically the greykite 0.3.0 official version, with the wrong version of the holidays_ext.py.
When running the code in AzureML it automatically installs the greykite 0.3.0 official version in every node of the simulation.

We'd need you to fix the greykite 0.3.0 library so it has the same version that it had one year ago, when it was released.

Thank you and best regards

[sayanpatra]

Thank you for bringing this to our attention. We are going to push a patch to fix this.

On a side note, Greykite 0.5.0 is released now. Here is the updated changelog: https://github.com/linkedin/greykite/blob/master/HISTORY.rst

[sayanpatra]

@PbSapConnector Greykite 0.5.1 is released that pins the holidays version. Let us know if this fixes your problem.

[njusu]

Yeah we have made two changes (1) dill>=0.3.1.1 and (2) holidays<0.25. We just released a new version 5.0.1 on pypi: https://pypi.org/project/greykite/0.5.1

Hope this helps!

[PbSapConnector]

Dears,

Isn't it possible to change the greykite 0.3.0 library so it has the same version that it had one year ago, when it was released?

We believe that, by changing the version we are using in our code to any other version, although having the holidays version corrected, some other functions are going to stop working.

Our wish is for the version 0.3.0 to be rebuilt as it was when it was released.

Thanks a lot for your support.

[sayanpatra]

Greykite 0.3.0 did not change. An external dependency (the holidays package) recently got updated, which is backward-incompatible, hence the broken code.

Can you try upgrading to Greykite 0.5.1? Here's the changelog, there are very few backward incompatible changes. Let us know what issues, if any, you are having.