Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File ignored by eyeglass installer gets installed after restart. #237

Open
1 of 3 tasks
chriseppstein opened this issue May 30, 2019 · 0 comments
Open
1 of 3 tasks

Comments

@chriseppstein
Copy link
Contributor

Package
This issue is related to the following monorepo package(s):

  • eyeglass
  • broccoli-eyeglass
  • ember-cli-eyeglass

Description

There's a weird issue in a LinkedIn project where a file that isn't installed gets installed anyway.

let ignoredExtensions = new Set(['js', 'css']);
eyeglass.assets.installer(function myInstaller( 
  assetFile, 
  assetUri, 
  oldInstaller, 
  cb 
) { 
  const assetExtension = assetUri.split('.').pop(); 
  if ( 
    ignoredExtensions.has(assetExtension) 
  ) { 
    cb(null, assetFile); 
  } else { 
    oldInstaller(assetFile, assetUri, cb); 
  } 
}); 

Returning null should cause the asset to not be installed, but they are seeing that it is found after restarting the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant