Encode opening brackets in contextDump helper #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -178,6 +178,8 @@ var helpers = { | |||
| else { | |||
| dump = JSON.stringify(context.stack.head, jsonFilter, 2); | |||
| } | |||
| // encode opening brackets | |||
| dump = dump.replace(/</g, '\\u003c'); | |||
| if (to === 'console') { | |||
There was a problem hiding this comment.
Should this be part of jsonFilter function?
There was a problem hiding this comment.
we prolly only need this in the else case. console.log AFAIK is pretty safe.
There was a problem hiding this comment.
@kate2753 the jsonFilter function acts on each key value pair, so I figure this is a bit more performant.
@jimmyhchan why's that, couldn't the current context still have opening brackets?
There was a problem hiding this comment.
console.logging with open brackets is not an issue. chunk.write with open brackets is.
There was a problem hiding this comment.
Ahh I see, you mean the else with chunk.write. Yeah that makes sense.
prashn64
force-pushed
the
contextDump-jsEncode
branch
from
b4940ae
to
84951a6
Compare
prashn64
force-pushed
the
contextDump-jsEncode
branch
from
84951a6
to
03cd65f
Compare
|
bump |
jimmyhchan
added a commit
that referenced
this pull request
Oct 10, 2014
Encode opening brackets in contextDump helper
|
...slow your roll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.