Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not Java 11? #1699

Closed
jsotelo opened this issue Jun 12, 2020 · 13 comments
Closed

Why not Java 11? #1699

jsotelo opened this issue Jun 12, 2020 · 13 comments
Labels
feature-request Request for a new feature to be added

Comments

@jsotelo
Copy link
Contributor

jsotelo commented Jun 12, 2020

Is there a specific reason we don't use Java 11? Looks like everything runs fine with ./gradlew build and Java 11.

Java 8 is officially end of life on December 2020.

@jsotelo jsotelo added the question Question label Jun 12, 2020
@mars-lan
Copy link
Contributor

Glad to hear that it builds on Java 11 as other users have reported issues building on newer versions of Java. Internally we're still using Java 8 but will most likely move to something newer before EOL.

@mars-lan
Copy link
Contributor

By the way, where did you get the EOL date for Java 8? Both Oracle & OpenJDK seem to state a much later date than Dec 2020?

@mars-lan mars-lan added feature-request Request for a new feature to be added and removed question Question labels Jul 25, 2020
@jsotelo
Copy link
Contributor Author

jsotelo commented Jul 25, 2020

I got it from the table in https://en.wikipedia.org/wiki/Java_version_history but I guess the fine print says "at least".

@mars-lan
Copy link
Contributor

Got it. Seems like Oracle has extended the EOL to 2022 now. Regardless, do agree that we should start taking advantage of newer versions of Java. We'll start evaluating the migration internally.

@jplaisted
Copy link
Contributor

I want to call this out but we'll need to update our style for new features as well. The big one I can think of is val from Java 10, which will probably cause some debate :) I'm on the "avoid at all costs" side of that fence.

@mars-lan
Copy link
Contributor

@jplaisted will let you drive this from our side.

@jplaisted
Copy link
Contributor

I'll need to dig into this quite a bit more. At the very least we need to provide Java 8 versions until LI and other clients are okay moving to Java 11 for their own deployments. I'm not sure how easy setting up or maintaining the two will be, still need to do more reading.

@jsotelo do you have a specific requirement / need to go to Java 11? Or is it just a nice to have?

==

Good reading

https://medium.com/uptake-tech/migrating-to-java-11-while-maintaining-a-java-8-client-library-f618a3ca6499

@jsotelo
Copy link
Contributor Author

jsotelo commented Jul 31, 2020

Nothing specific; mainly for better GC performance and moving toward the next LTS version. Nothing urgent from my end.

@jplaisted
Copy link
Contributor

Thanks! I agree better performance is a win (+ some new profiling tools). Gotta weigh this against the cost of maintaining Java 8 in parallel, for the time being.

@jjoyce0510
Copy link
Collaborator

@jplaisted Is there updated thinking around this?

@jplaisted
Copy link
Contributor

With LI still being on Java 8 I haven't had time to look at this. Though we're going to Java 11 in theory by the end of this quarter... I can revisit this then, unless you want to carry this forward before then. In the meantime we'd still at least need Java 8 compatible GMA libraries.

@jplaisted jplaisted removed their assignment Jun 23, 2021
@maggiehays
Copy link
Collaborator

We are now managing feature requests through our new portal to improve visibility & prioritize work into our public roadmap. If this request is still relevant, please create a new issue so we can gauge current interest from the Community & prioritize work accordingly.

We'll close out this issue in the meantime. Feel free to reach out to me on DataHub Slack with any questions!

@rakhiagr
Copy link

rakhiagr commented Apr 7, 2023

We are planning to update to Java 11 this quarter. What are your views? @jjoyce0510 @jsotelo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for a new feature to be added
Projects
None yet
Development

No branches or pull requests

7 participants