Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addStatement should not be a public method #165

Open
dan-f opened this issue Jan 5, 2017 · 1 comment
Open

addStatement should not be a public method #165

dan-f opened this issue Jan 5, 2017 · 1 comment

Comments

@dan-f
Copy link
Contributor

dan-f commented Jan 5, 2017

The addStatement method on Formula objects adds a statement to a graph but doesn't index it. But since IndexedFormula inherits from Formula, it gets the method too. If you call addStatement instead of add on an indexed formula your querying gets broken since the indices never update.

I'd be in favor of removing the addStatement API or aliasing it to add. Since add is already a method on Formula, we can just modify that method to detect whether its arguments are a statement or separate s, p, o, and g objects.

This relates to #42, IMO

@dmitrizagidulin
Copy link
Contributor

+1 to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants