Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importlib-metadata dep upper version constraint higher #416

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

doronbehar
Copy link
Contributor

I tested the gui to work successfully with the latest and greatest importlib-metadata 7.1.0. In the context of my flake.nix setup.

@bleykauf
Copy link
Collaborator

Would still use the latest version as the upper bound to avoid any breaking changes when upgrading major versions (assuming that they use something similar to SemVer). Would be <9.0 now.

@bleykauf bleykauf changed the base branch from master to develop August 13, 2024 12:55
@doronbehar doronbehar changed the title Remove upper constraint on importlib-metadata dependency Make importlib-metadata dep upper version constraint higher Aug 13, 2024
@doronbehar
Copy link
Contributor Author

Would still use the latest version as the upper bound to avoid any breaking changes when upgrading major versions (assuming that they use something similar to SemVer). Would be <9.0 now.

Done.

@doronbehar doronbehar force-pushed the latest-importlib-metadata branch from 4f3cc78 to eac93a7 Compare August 13, 2024 15:35
@bleykauf bleykauf merged commit a12e620 into linien-org:develop Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants