Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting peer dependency: @lingui/[email protected] #2124

Closed
Athou opened this issue Dec 16, 2024 · 5 comments · Fixed by #2125
Closed

Conflicting peer dependency: @lingui/[email protected] #2124

Athou opened this issue Dec 16, 2024 · 5 comments · Fixed by #2125

Comments

@Athou
Copy link

Athou commented Dec 16, 2024

Describe the bug
Cannot upgrade lingui to 5.1.1 from 5.0.0.

[INFO] npm error While resolving: @lingui/[email protected]
[INFO] npm error Found: @lingui/[email protected]
[INFO] npm error node_modules/@lingui/babel-plugin-lingui-macro
[INFO] npm error   dev @lingui/babel-plugin-lingui-macro@"^5.1.1" from the root project
[INFO] npm error   @lingui/babel-plugin-lingui-macro@"5.1.1" from @lingui/[email protected]
[INFO] npm error   node_modules/@lingui/cli
[INFO] npm error     dev @lingui/cli@"^5.1.1" from the root project
[INFO] npm error     @lingui/cli@"5.1.1" from @lingui/[email protected]
[INFO] npm error     node_modules/@lingui/vite-plugin
[INFO] npm error       dev @lingui/vite-plugin@"^5.1.1" from the root project
[INFO] npm error
[INFO] npm error Could not resolve dependency:
[INFO] npm error peerOptional @lingui/babel-plugin-lingui-macro@"5.1.0" from @lingui/[email protected]
[INFO] npm error node_modules/@lingui/core
[INFO] npm error   @lingui/core@"^5.1.1" from the root project
[INFO] npm error   @lingui/core@"5.1.1" from @lingui/[email protected]
[INFO] npm error   node_modules/@lingui/babel-plugin-lingui-macro
[INFO] npm error     dev @lingui/babel-plugin-lingui-macro@"^5.1.1" from the root project
[INFO] npm error     1 more (@lingui/cli)
[INFO] npm error   2 more (@lingui/cli, @lingui/react)
[INFO] npm error
[INFO] npm error Conflicting peer dependency: @lingui/[email protected]
[INFO] npm error node_modules/@lingui/babel-plugin-lingui-macro
[INFO] npm error   peerOptional @lingui/babel-plugin-lingui-macro@"5.1.0" from @lingui/[email protected]
[INFO] npm error   node_modules/@lingui/core
[INFO] npm error     @lingui/core@"^5.1.1" from the root project
[INFO] npm error     @lingui/core@"5.1.1" from @lingui/[email protected]
[INFO] npm error     node_modules/@lingui/babel-plugin-lingui-macro
[INFO] npm error       dev @lingui/babel-plugin-lingui-macro@"^5.1.1" from the root project
[INFO] npm error       1 more (@lingui/cli)
[INFO] npm error     2 more (@lingui/cli, @lingui/react)
[INFO] npm error
[INFO] npm error Fix the upstream dependency conflict, or retry
[INFO] npm error this command with --force or --legacy-peer-deps
[INFO] npm error to accept an incorrect (and potentially broken) dependency resolution.

To Reproduce
Bump all those lingui packages to 5.1.1

image

See also this renovate PR: https://github.com/Athou/commafeed/pull/1623/files

Expected behavior
npm install works without error.

Additional context
Could the issue be that the babel-plugin-lingui-macro version here is pinned to 5.1.0?

@andrii-bodnar
Copy link
Contributor

It appears that this is related to Lerna, particularly this issue - lerna/lerna#955 😞

It doesn't bump peerDependencies during the publishing process. I will look into this.

@timofei-iatsenko
Copy link
Collaborator

@andrii-bodnar I propose to change it to the changesets.

@andrii-bodnar
Copy link
Contributor

@timofei-iatsenko I also think it's time to move to changesets.

@jgarplind
Copy link
Contributor

6 hours late to the party, I agree with your conclusion, but understand that it may be side work that you don't really want to spend time on.

So I just wanted to chime in and let you know that there are more of us (probably a huge silent majority too) who would be even happier with Lingui if you did get this figured out.

@andrii-bodnar
Copy link
Contributor

I just released a new version with the fix - 5.1.2. Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants