Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSAA] Blocky artifacts with the even-odd fill rule #390

Closed
armansito opened this issue Oct 21, 2023 · 1 comment
Closed

[MSAA] Blocky artifacts with the even-odd fill rule #390

armansito opened this issue Oct 21, 2023 · 1 comment

Comments

@armansito
Copy link
Collaborator

I added a new test scene for fill rules in #389. When I tried it with both 16xMSAA and 8xMSAA modes I observed some visual artifacts.

This is how it looks with Analytic AA:
Screenshot 2023-10-21 at 1 35 49 PM

This is with MSAA:
Screenshot 2023-10-21 at 1 33 16 PM

@raphlinus
Copy link
Contributor

This is consistent with the even-odd rule just not being handled correctly in the msaa fine rasterizer, especially as it looks like the logic in coarse is doing the right thing for solid blocks. It wouldn't be hard to add a case, but the best solution is to write a specialized version that uses 1 bit per sample to accumulate winding numbers, using xor. The performance of that should be excellent, with no extra cost to using 16 bits over 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants