Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a piet::utils module for code common to different backends #183

Closed
cmyr opened this issue May 9, 2020 · 0 comments · Fixed by #184
Closed

Add a piet::utils module for code common to different backends #183

cmyr opened this issue May 9, 2020 · 0 comments · Fixed by #184

Comments

@cmyr
Copy link
Member

cmyr commented May 9, 2020

Not just the stuff below, but also the blurred rect code in coregraphics & piet, and other shared code for writing images. Probably other stuff too.

I'd recommend calling into a helper function; https://github.com/linebender/piet/blob/master/piet-direct2d/src/text.rs#L230 is reasonable though we should have better ways of avoiding cross-crate duplication.

Originally posted by @raphlinus in #176
@cmyr cmyr mentioned this issue May 9, 2020
Merged
cmyr added a commit that referenced this issue May 9, 2020
@cmyr
Add piet::util module
2e7b95d 
This is intended for bits of code shared between various backend
implementations.

closes #183
@cmyr cmyr mentioned this issue May 9, 2020
Merged
cmyr added a commit that referenced this issue May 9, 2020
@cmyr
Add piet::util module
9344d27 
This is intended for bits of code shared between various backend
implementations.

closes #183
cmyr added a commit that referenced this issue May 9, 2020
@cmyr
Add piet::util module
7ef4eee 
This is intended for bits of code shared between various backend
implementations.

closes #183
cmyr added a commit that referenced this issue May 9, 2020
@cmyr
Add piet::util module
ee3962d 
This is intended for bits of code shared between various backend
implementations.

closes #183
@cmyr cmyr closed this as completed in #184 May 11, 2020
cmyr added a commit that referenced this issue May 11, 2020
@cmyr
Add piet::util module
eccdba7 
This is intended for bits of code shared between various backend
implementations.

closes #183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add piet::util module linebender/piet
1 participant
@cmyr