Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fitting stack overflow on infinite cusp #291

Closed
pixelpicosean opened this issue Jun 9, 2023 · 2 comments
Closed

Fitting stack overflow on infinite cusp #291

pixelpicosean opened this issue Jun 9, 2023 · 2 comments

Comments

@pixelpicosean
Copy link

The stroke() will crash due to stack overflow for path with infinite cusp such as M100,100 C200,200,200,100,100,200 L100,100Z.

With slightly offset on a point, the final result will contain hundreds of points, see below

SVG Path Visualizer-2023 06 10-39 57@2x
@raphlinus
Copy link
Contributor

Hopefully #289 fixes the infinite recursion, but I'm expecting there is more work still to be done to get it fully robust. Overall robustness is tracked in #279. Thanks for the report, I'll use it as a test case!

@pixelpicosean
Copy link
Author

Can confirm this is fixed by latest changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raphlinus @pixelpicosean