Optimize clippy trivially_copy_pass_by_ref for 64-bit. #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
trivially_copy_pass_by_ref
to 16 bytes, which is the number of bytes that fit into two 64-bit CPU registers.The default clippy value for this is 8 bytes, which is chosen to improve performance on 32-bit. Given that druid is being designed for the future and already even mobile phones have 64-bit CPUs, it makes sense to optimize for 64-bit and accept the performance hits on 32-bit.
This also changes command
Target
to be passed by value. It's a breaking change, but given that commands are getting redone in #908 anyway, I think this is about as perfect of a time to change this as possible.