Add logging when WM_CAPTURECHANGED is dropped #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntrancy. Make sure not to call ReleaseCapture while a mutable reference exists to the window state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small clean up of #695. It was considered alright to drop
WM_CAPTURECHANGEDmessages when the window state is locked, because this happens when we callReleaseCaptureourselves, and in that case we already update the relevant state ourselves and don't need the callback.However I think it's actually better if we have the log in
WM_CAPTURECHANGEDin case it will be called reentrantly in another situation that we don't know about. Instead, I've made sure that we defer callingReleaseCaptureto a point where we're not locking the window state.