Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the text module public #816

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Make the text module public #816

merged 1 commit into from
Apr 10, 2020

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Apr 8, 2020

closes #776

@cmyr cmyr force-pushed the public-text-module branch from 7dfcb22 to 48bad55 Compare April 8, 2020 15:12
@cmyr cmyr added the S-needs-review waits for review label Apr 9, 2020
xStrom
xStrom approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmyr cmyr merged commit 891c66b into master Apr 10, 2020
@cmyr cmyr deleted the public-text-module branch April 10, 2020 15:10
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make text module public?
2 participants
@cmyr @xStrom