Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on OpenBSD #1993

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Build on OpenBSD #1993

merged 2 commits into from
Oct 1, 2021

Conversation

klemensn
Copy link
Contributor

Just like Linux, OpenBSD is sufficiently supported using GTK+3.

No platform specific changes required to successfully run the examples
and real-world applications like Psst (spotify GUI client).

The pre-push hook mentioned in CONTRIBUTING.md runs sucessfully on
OpenBSD/amd64 7.0 (after pointing druid to a ported version of piet in
.cargo/config.toml to allow building in the first place), i.e. no lint
or build failure.

@klemensn klemensn marked this pull request as ready for review September 28, 2021 16:53
Just like Linux, OpenBSD is sufficiently supported using GTK+3.

No platform specific changes required to successfully run the examples
and real-world applications like Psst (spotify GUI client).

The pre-push hook mentioned in CONTRIBUTING.md runs sucessfully on
OpenBSD/amd64 7.0 (after pointing druid to a ported version of piet in
.cargo/config.toml to allow building in the first place), i.e. no lint
or build failure.
@klemensn
Copy link
Contributor Author

I committed the hunks produced by cargo fmt --all.
I am not sure what to do about CI's failing Ubuntu workflows, though.

druid-shell/build.rs Outdated Show resolved Hide resolved
Fix OS detection logic (thanks @maan2003)

Co-authored-by: Manmeet Maan <[email protected]>
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cmyr cmyr merged commit 70e0b97 into linebender:master Oct 1, 2021
@klemensn
Copy link
Contributor Author

Great, now I'm just waiting for a new proper release so software like psst can fetch the crate from the registry rather than a specific git checkout.

This is less important for development on personal machines, but environments such as those for official OS/distribution packages often prefetch things prior to build (which has no network) access, and OpenBSD's package infrastructure only knows how to fetch crates from the registry.

I've been working on fetching from git, which already works, but that also has implications to the build process, which are a bit trickier.

tl;dr: it would be nice to see a new release sooner than later to ease downstream development.

@xStrom
Copy link
Member

xStrom commented Jan 31, 2023

Great, now I'm just waiting for a new proper release

Good news @klemensn, Druid v0.8.2 is now out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants