Add HasRawWindowHandle for WindowHandle in druid #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI failing due to clippy and existing changes in |
|
rebasing should fix CI |
|
Any way to nudge this along? I've kicked the tires on this a little bit and it's very useful! I'd love to be able to switch back to |
|
@playmer Feel free to cherry-pick this commit into a new PR that is based off the current master? I will be happy to merge that. |
|
I'll have a look at rebasing. |
Expose the `HasRawWindowHandle` trait impl of druid-shell for `WindowHandle` into druid itself, so druid users can access it. This is also under a `raw-win-handle` feature, like the druid-shell one. Bug: linebender#1505
|
What the heck happened? I just pushed to my branch and that closed the PR?! |
|
All green @cmyr, if someone can review/merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
HasRawWindowHandletrait impl of druid-shell forWindowHandleinto druid itself, so druid users can access it. Thisis also under a
raw-win-handlefeature, like the druid-shell one.Bug: #1505