Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive invalidation when using Either #1350

Closed
andrewhickman opened this issue Oct 27, 2020 · 1 comment · Fixed by #1351
Closed

Excessive invalidation when using Either #1350

andrewhickman opened this issue Oct 27, 2020 · 1 comment · Fixed by #1351

Comments

@andrewhickman
Copy link
Contributor

andrewhickman commented Oct 27, 2020 •
edited
Loading

Repro steps:

  • Enable debug_invalidation in the either example
  • Hover over the "click to reveal slider" label

The entire screen is invalidated repeatedly, even when the mouse is not moving.
@andrewhickman andrewhickman mentioned this issue Oct 27, 2020
Merged
@andrewhickman
Copy link
Contributor Author

andrewhickman commented Oct 27, 2020 •
edited
Loading

This turned out to be caused by Either sending HotChanged lifecycle events to both of its children, instead of just the current one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate events to hidden widgets in Either
1 participant
@andrewhickman