Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vestigial support for cairo/gtk on macOS #1250

Closed
cmyr opened this issue Sep 21, 2020 · 2 comments
Closed

Remove vestigial support for cairo/gtk on macOS #1250

cmyr opened this issue Sep 21, 2020 · 2 comments
Labels
maintenance cleans up code or docs shell concerns the shell abstraction

Comments

@cmyr
Copy link
Member

cmyr commented Sep 21, 2020

This was kept around for a while because I was testing GTK patches on macOS, but that's a poor reason to keep code around that we are obliged to maintain. This will make various cfg(thing) paths cleaner, and will also let us clean up some of our cargo manifests.

we currently allow cairo to be used, opt-in, on macOS. I'm not sure we should, but we do; I think this is why these deps are in two places.

Originally posted by @cmyr in #1241 (comment)
@cmyr cmyr added maintenance cleans up code or docs shell concerns the shell abstraction labels Sep 22, 2020
@PoignardAzur
Copy link
Collaborator

Is there any progress on this?

@cmyr
Copy link
Member Author

cmyr commented Aug 4, 2021

this has been removed iirc.

@cmyr cmyr closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance cleans up code or docs shell concerns the shell abstraction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmyr @PoignardAzur