Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split VelloAsset into VelloSvg and VelloLottie. #89

Open
simbleau opened this issue Dec 11, 2024 · 0 comments · May be fixed by #90
Open

Split VelloAsset into VelloSvg and VelloLottie. #89

simbleau opened this issue Dec 11, 2024 · 0 comments · May be fixed by #90

Comments

@simbleau
Copy link
Member

Render logic is shared for both file types, and has shown to be a pretty clear bad pattern after some time. This means every SVG pays a "lottie" tax, even though it's static. There's also logic and components that only work for Lotties, but can be added to SVGs, such as the Theme component which does color remapping (only works for lottie).

The issue is simple, split VelloAsset in two.

@simbleau simbleau linked a pull request Dec 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant