Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove transient store that is not used now #203

Merged
merged 1 commit into from
May 24, 2021

Conversation

egonspace
Copy link

Description

TransientStore was used only in param store.
However, in the PR #202, the ParamStore no longer uses the TransientStore, making it unnecessary. A lot of code for this could be removed, so I think it's better to erase it.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this May 24, 2021
@egonspace egonspace added this to the Initail ebony milestone May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #203 (368117e) into v2/develop (88ab1bd) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #203      +/-   ##
==============================================
- Coverage       53.49%   53.47%   -0.02%     
==============================================
  Files             653      652       -1     
  Lines           47376    47339      -37     
==============================================
- Hits            25343    25315      -28     
+ Misses          19178    19170       -8     
+ Partials         2855     2854       -1     
Impacted Files Coverage Δ
baseapp/baseapp.go 77.94% <ø> (+0.85%) ⬆️
store/rootmulti/store.go 65.25% <0.00%> (-0.72%) ⬇️
store/types/gas.go 75.00% <ø> (+1.82%) ⬆️
store/types/store.go 58.82% <ø> (-1.18%) ⬇️
types/context.go 96.15% <ø> (+1.21%) ⬆️
types/store.go 56.25% <ø> (-8.75%) ⬇️
x/params/types/subspace.go 74.78% <ø> (-0.22%) ⬇️
simapp/app.go 83.96% <100.00%> (+0.16%) ⬆️
x/params/keeper/keeper.go 72.22% <100.00%> (-1.47%) ⬇️

Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 9546267 into v2/develop May 24, 2021
@egonspace egonspace deleted the egon/v2/chore/remove_transient_store branch May 24, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants