Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): add missed UpdateContractStatusProposal types #162

Merged

Conversation

whylee259
Copy link
Contributor

Description

Added missed UpdateContractStatusProposal relevant types

  • add proposal type string
  • register proposal codec

related to https://github.com/line/lbm/pull/1324#discussion_r624975376

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

- add proposal type string
- register proposal codec
@whylee259 whylee259 self-assigned this May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #162 (dcd7d27) into v2/develop (1f739c5) will decrease coverage by 1.84%.
The diff coverage is 68.87%.

Impacted file tree graph

@@              Coverage Diff               @@
##           v2/develop     #162      +/-   ##
==============================================
- Coverage       54.99%   53.15%   -1.85%     
==============================================
  Files             812      704     -108     
  Lines           51487    47263    -4224     
==============================================
- Hits            28317    25124    -3193     
+ Misses          20211    19579     -632     
+ Partials         2959     2560     -399     
Impacted Files Coverage Δ
client/grpc/tmservice/query.pb.gw.go 30.06% <ø> (ø)
client/keys/root.go 100.00% <ø> (ø)
client/keys/utils.go 44.11% <ø> (+5.22%) ⬆️
crypto/armor.go 85.89% <ø> (ø)
crypto/keys/ed25519/ed25519.go 67.34% <ø> (ø)
crypto/keys/multisig/codec.go 100.00% <ø> (ø)
crypto/keys/secp256k1/secp256k1.go 86.79% <ø> (ø)
simapp/test_helpers.go 8.41% <0.00%> (+7.91%) ⬆️
types/address.go 65.71% <ø> (ø)
types/config.go 84.61% <ø> (ø)
... and 84 more

@whylee259 whylee259 merged commit 35daa1b into v2/develop May 3, 2021
@whylee259 whylee259 deleted the whylee/v2/fix/add-missed-update-contract-propoal-types branch May 12, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants