-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Including Regular Expression filter when targeting Github Repositories #426
Conversation
…arget_repositories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙂
I've included some comments, where the biggest one is to not to the filtering within the GitHub package, but instead in the multi-gitter package. This will allow all users to use the feature, and not just GitHub users.
multi-gitter/internal/multigitter/run.go
Line 155 in e800b5c
func filterRepositories(repos []scm.Repository, skipRepositoryNames []string) []scm.Repository { |
Moved regex filtering to multi-gitter/internal/multigitter/run.go Line 155 in e800b5c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor, mostly style comments left 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for the contribution 🙂
Included in release v0.49.0 🎉 |
What does this change
Allows to filter out target repositories using a regular expression
This change introduces two new flags
--repo-include
and--repo-exclude
which will filter out repositories mentioned in their specified regular expressions. Example:multi-gitter run ./test.sh --repo-include "^repoprefix-" --repo-exclude "^repoprefix-ignorerepo$" --repo-search "repoprefix-" --dry-run --commit-message "chore: foo"
What issue does it fix
Notes for the reviewer
Checklist