Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub team review #351

Merged
merged 5 commits into from
May 2, 2023
Merged

GitHub team review #351

merged 5 commits into from
May 2, 2023

Conversation

tadam313
Copy link
Contributor

@tadam313 tadam313 commented May 2, 2023

What does this change

Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.

Added support to assign github teams to pull requests using team slug (passed to the GH API).

go run main.go run $SCRIPT --config $CONFIG --token "$TOKEN"
INFO[0000] Running on 1 repositories                    
INFO[0000] Cloning and running script                    repo=marshmallow-insurance/{REPO}
INFO[0004] Pushing changes to remote                     repo=marshmallow-insurance/{REPO}
INFO[0005] Creating pull request                         repo=marshmallow-insurance/{REPO}
Repositories with a successful run:
  marshmallow-insurance/{REPO} #9

$CONFIG file here contains flag team-reviewers and max-team-reviewers and other repo related configs.

What issue does it fix

Closes #328

Notes for the reviewer

Let me know if we need to add further tests here.

Checklist

  • Made sure the PR follows the CONTRIBUTING.md guidelines
  • Tests if something new is added

README.md Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed in this file as it will be automatically generated on merge. Please revert the readme changes.

Copy link
Contributor Author

@tadam313 tadam313 May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay sorry, I thought we need to run the script manually :)

@tadam313 tadam313 requested a review from lindell May 2, 2023 16:39
Copy link
Owner

@lindell lindell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

Thanks for the contribution!

@lindell lindell merged commit 9c084f0 into lindell:master May 2, 2023
@tadam313 tadam313 deleted the github_team_review branch May 3, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants