fix: return open PRs only #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! You are right that MG for GitHub give this error since the graphql rewrite for PRs. But the query itself seems to be correct since it's used for both the But from the error you described, I can see that the mapping to the "merged" status was missed: Which means it instead get "success" status and it then not filtered out from being merged again. |
|
Changed the pr to reflect this. Could you please confirm this is working as intended for you @johanneswuerbach 😄 |
|
Yes, its working for me 🙇 |
|
Perfect 👍 Thanks again for the find 😄 |
|
Included in release v0.42.2 🎉 |
2 tasks
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Once a change was partially merged, no further merge operations were possible as mutli-gitter tried to merge already merged PRs and GitHub returned.
PUT https://api.github.com/repos/XYZ/pulls/40/merge: 405 Pull Request is not mergeable []Instead of returning all PRs for a branch, return only open PRs as there is currently no way to interact with already closed PRs.
Checklist