Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to mostly clientless tests #376

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Switch to mostly clientless tests #376

merged 1 commit into from
Feb 8, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Feb 8, 2024

Change Description

Related to #328. This does not resolve the underlying issue, but may reduce the flakiness by not using the client needlessly for many of our tests. I've run the unit test action 3 times and have gotten all passes on all 3 version of python, this seems substantially smoother than the current performance.

  • My PR includes a link to the issue that I am addressing

Solution Description

Switches most of our unit tests to be clientless, and swaps back a few of the "without_client" tests to now include the client, as it's the new "edge case". I also noticed we were repeating some tests in a parametrize call, so went ahead and removed those.

Code Quality

  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

  • I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@dougbrn dougbrn changed the title Switch to mostly lientless tests Switch to mostly clientless tests Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Before [d7b5d17] <v0.3.3> After [66fe2e8] Ratio Benchmark (Parameter)
40.6±0.6ms 39.9±0.07ms 0.98 benchmarks.time_batch
42.9±0.3ms 42.0±0.4ms 0.98 benchmarks.time_prune_sync_workflow

Click here to view all benchmarks.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7b5d17) 95.40% compared to head (2fd3b46) 95.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          25       25           
  Lines        1698     1698           
=======================================
  Hits         1620     1620           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn requested a review from wilsonbb February 8, 2024 21:49
@dougbrn dougbrn marked this pull request as ready for review February 8, 2024 21:49
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dougbrn dougbrn merged commit db3ac53 into main Feb 8, 2024
13 checks passed
@dougbrn dougbrn deleted the clientless_tests branch February 8, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants