Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a random lightcurve selection function to the Ensemble #336

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Dec 21, 2023

Resolves #332.

Adds a convenience function to grab a random lightcurve from the Ensemble, which we expect users to use to do quick sanity checks that operations have had the desired effect on their lightcurves.

@dougbrn dougbrn requested a review from hombit December 21, 2023 21:48
@dougbrn dougbrn marked this pull request as ready for review December 21, 2023 21:48
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97a2bfc) 94.61% compared to head (bc5ff2b) 94.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   94.61%   94.66%   +0.05%     
==========================================
  Files          24       24              
  Lines        1540     1556      +16     
==========================================
+ Hits         1457     1473      +16     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/tape/ensemble.py Outdated Show resolved Hide resolved
src/tape/ensemble.py Outdated Show resolved Hide resolved
src/tape/ensemble.py Outdated Show resolved Hide resolved
src/tape/ensemble.py Outdated Show resolved Hide resolved
src/tape/ensemble.py Outdated Show resolved Hide resolved
@dougbrn dougbrn requested a review from hombit December 22, 2023 19:41
Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dougbrn dougbrn merged commit e5404a6 into main Dec 22, 2023
10 checks passed
@dougbrn dougbrn deleted the select_random_lc branch January 2, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a random lightcurve selection function
2 participants