Calc nobs divisions #288
Merged
Calc nobs divisions #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging both @wilsonbb for general technical review and @nevencaplar to make sure this works for his use case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 94.01% 94.02% +0.01%
==========================================
Files 23 23
Lines 1203 1206 +3
==========================================
+ Hits 1131 1134 +3
Misses 72 72 ☔ View full report in Codecov by Sentry. |
wilsonbb
approved these changes
Nov 14, 2023
| band_col = self._band_col | ||
|
|
||
| # Get the band metadata | ||
| unq_bands = np.unique(self._source[band_col]) |
There was a problem hiding this comment.
Nit: I'm not fully certain about the performance differences, but I feel self._source[band_col].unique() might be preferable and slightly more readable
|
I have verified that this solves issue 287 |
nevencaplar
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #287. Makes calc_nobs use map partitions to propagate metadata instead of groupby when divisions are known. This introduces an annoying cost of having to calculate the unique bands for the resulting meta in the by_band=True case, it's slow, but works for now.