Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add calc_nobs #251

Merged
merged 3 commits into from
Oct 2, 2023
Merged

add calc_nobs #251

merged 3 commits into from
Oct 2, 2023

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Oct 2, 2023

Adds a function to calculate the number of observations in source, with option to do it just for the total, or the total and a count for each band.

Addresses #246.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (43d8d11) 92.63% compared to head (1e51dac) 92.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   92.63%   92.70%   +0.07%     
==========================================
  Files          22       22              
  Lines        1140     1151      +11     
==========================================
+ Hits         1056     1067      +11     
  Misses         84       84              
Files Coverage Δ
src/tape/ensemble.py 89.87% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review October 2, 2023 21:31
@dougbrn dougbrn requested a review from wilsonbb October 2, 2023 21:53
@wilsonbb
Copy link
Collaborator

wilsonbb commented Oct 2, 2023

Looks good to me!

@wilsonbb wilsonbb closed this Oct 2, 2023
@wilsonbb wilsonbb reopened this Oct 2, 2023
@dougbrn dougbrn merged commit 0f962c5 into main Oct 2, 2023
16 checks passed
@dougbrn dougbrn deleted the calc_nobs branch December 11, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants