-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading ensemble from pandas and dask dataframes #224
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 92.44% 92.57% +0.13%
==========================================
Files 22 22
Lines 1125 1132 +7
==========================================
+ Hits 1040 1048 +8
+ Misses 85 84 -1
☔ View full report in Codecov by Sentry. |
Will add an additional test to bump up the code coverage, but I wanted it to be ready for a first review pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it looks great! I list some general questions and non-important code suggestions.
Adds the loader functions
Ensemble.from_pandas
andEnsemble.from_dask_dataframe
. This allows the user to provide TAPE with their own Pandas or Dask dataframes constructed via their own preferred sources and I/O as outlined in issue #223.Ensemble.from_source_dict
andEnsemble.from_parquet
were simplified with some of their functionality moved intoEnsemble.from_dask_dataframe
.