Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch by any (categorical) column #335

Open
hombit opened this issue Dec 21, 2023 · 0 comments
Open

Batch by any (categorical) column #335

hombit opened this issue Dec 21, 2023 · 0 comments
Labels
needs driver Needs science case to push development

Comments

@hombit
Copy link
Contributor

hombit commented Dec 21, 2023

Currently, we can batch sub-light curves with batch(by_band=True). It is a great feature, but I believe we would benefit from some refactoring of it.

Me feeling is that current batch interface is over-loaded and has too many combinations of 1) analysis function type, 2) its Dask meta types, 3) grouping-by flavors and 4) types of the output.

I propose to introduce batch_by(by=column_name) and its thin wrapper batch_by_band to replace the current batch(by_band=True) interface. It would simplify our interfaces, make the code more maintainable, and allow users to use any categorical column, not band only.

@nevencaplar nevencaplar added the needs driver Needs science case to push development label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs driver Needs science case to push development
Projects
None yet
Development

No branches or pull requests

2 participants