Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test EnsembleFrame Serialization Methods #312

Open
wilsonbb opened this issue Dec 8, 2023 · 1 comment
Open

Test EnsembleFrame Serialization Methods #312

wilsonbb opened this issue Dec 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wilsonbb
Copy link
Collaborator

wilsonbb commented Dec 8, 2023

Dask supports various serialization methods for its DataFrames (see here), and for the EnsembleFrame hierarchy we should validate that we still have appropriate round trip serialization, both in terms of the underlying data as well as our metadata (_Frame.label, _Frame.ensemble, _Frame.dirty)

Note that one approach we already do is that we override _args to avoid an issue present in dask-geopandas. Our testing can help us determine if this is needed or if the linking to the issue in our comments can be expanded or removed.

@wilsonbb wilsonbb added the enhancement New feature or request label Dec 8, 2023
@wilsonbb
Copy link
Collaborator Author

Quick notes on priority:

Having end-to-end testing of serialization of the new dataframes seems worth doing but is relatively low priority and low-to-moderate effort.

We might get this as part of any effort to save and reload an ensemble which we have discussed doing, but it seems worth keeping this issue open to preserve context on the issue seen in dask-geopandas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant