Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete PPT example code #76

Merged
merged 1 commit into from
May 10, 2024
Merged

Delete PPT example code #76

merged 1 commit into from
May 10, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 10, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested review from dougbrn and removed request for dougbrn May 10, 2024 14:47
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (0dadb25) to head (14c1de2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   98.53%   98.52%   -0.01%     
==========================================
  Files          16       15       -1     
  Lines         821      816       -5     
==========================================
- Hits          809      804       -5     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [0dadb25] After [775ecab] Ratio Benchmark (Parameter)
33.6±2ms 34.7±1ms 1.03 benchmarks.AssignSingleDfToNestedSeries.time_run
8.26±0.06ms 8.33±0.2ms 1.01 benchmarks.NestedFrameAddNested.time_run
5.12±0.04ms 5.18±0.06ms 1.01 benchmarks.NestedFrameReduce.time_run
59.3±3ms 59.8±1ms 1.01 benchmarks.ReassignHalfOfNestedSeries.time_run
259M 260M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
86M 86M 1 benchmarks.NestedFrameAddNested.peakmem_run
88.2M 88.2M 1 benchmarks.NestedFrameReduce.peakmem_run
275M 273M 0.99 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
89.8M 88.2M 0.98 benchmarks.NestedFrameQuery.peakmem_run
6.24±0.03ms 5.83±0.08ms 0.94 benchmarks.NestedFrameQuery.time_run

Click here to view all benchmarks.

@hombit hombit requested a review from delucchi-cmu May 10, 2024 14:49
@hombit hombit merged commit 631787f into main May 10, 2024
10 of 11 checks passed
@hombit hombit deleted the delete-ppt-example-code branch May 10, 2024 14:51
@hombit hombit mentioned this pull request May 10, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants