Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .nest[...] = pd.Series #63

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix .nest[...] = pd.Series #63

merged 2 commits into from
May 9, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 8, 2024

Previously it failed because compared "nested" and "flat" indices, which cannot be equal.

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (be2b7a6) to head (4375c59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   97.55%   97.56%           
=======================================
  Files          16       16           
  Lines         818      820    +2     
=======================================
+ Hits          798      800    +2     
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 8, 2024

Before [be2b7a6] After [6a507ce] Ratio Benchmark (Parameter)
31.7±2ms 33.6±1ms 1.06 benchmarks.AssignSingleDfToNestedSeries.time_run
255M 260M 1.02 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
85.8M 85.8M 1 benchmarks.NestedFrameAddNested.peakmem_run
88.2M 88.3M 1 benchmarks.NestedFrameQuery.peakmem_run
88.2M 88.2M 1 benchmarks.NestedFrameReduce.peakmem_run
272M 273M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
8.81±0.1ms 8.73±0.2ms 0.99 benchmarks.NestedFrameQuery.time_run
8.42±0.1ms 8.26±0.1ms 0.98 benchmarks.NestedFrameAddNested.time_run
5.29±0.06ms 5.13±0.06ms 0.97 benchmarks.NestedFrameReduce.time_run
58.3±3ms 56.3±2ms 0.97 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

@wilsonbb wilsonbb self-requested a review May 8, 2024 19:02
Copy link
Contributor

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with ideally a unit test added later

src/nested_pandas/series/accessor.py Outdated Show resolved Hide resolved
@hombit hombit force-pushed the fix-nest-assign branch from 4d4d241 to 4375c59 Compare May 9, 2024 13:04
@hombit hombit merged commit a196bd6 into main May 9, 2024
11 checks passed
@hombit hombit deleted the fix-nest-assign branch May 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants