Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toy dataset generator function #55

Merged
merged 3 commits into from
May 6, 2024
Merged

Add a toy dataset generator function #55

merged 3 commits into from
May 6, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented May 6, 2024

Change Description

Resolves #17

  • My PR includes a link to the issue that I am addressing

Solution Description

Adds a small toy dataset generator function. Mainly to be used for unit tests, and novel documentation.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have added unit/End-to-End (E2E) test cases to cover my new feature

@dougbrn dougbrn requested a review from hombit May 6, 2024 18:07
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (109c16c) to head (a1f9cb0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   97.35%   97.55%   +0.19%     
==========================================
  Files          14       16       +2     
  Lines         794      818      +24     
==========================================
+ Hits          773      798      +25     
+ Misses         21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 6, 2024

Before [49b03ff] After [ec42dbc] Ratio Benchmark (Parameter)
1.67±1s 3.70±0.8s ~2.21 benchmarks.time_computation
616 1.86k 3.01 benchmarks.mem_list

Click here to view all benchmarks.

Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/nested_pandas/datasets/generation.py Outdated Show resolved Hide resolved
@dougbrn dougbrn merged commit f2d488f into main May 6, 2024
11 checks passed
@dougbrn dougbrn deleted the generate_data branch May 6, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a public function to generate test data
2 participants