Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix from_flat for pd input #147

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix from_flat for pd input #147

merged 1 commit into from
Sep 23, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Sep 23, 2024

Resolves #145

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (6101d39) to head (cd7ca7e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          14       14           
  Lines         941      943    +2     
=======================================
+ Hits          936      938    +2     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review September 23, 2024 18:57
Copy link

Before [6101d39] <v0.2.2> After [04a35a1] Ratio Benchmark (Parameter)
30.8±2ms 34.3±3ms ~1.11 benchmarks.AssignSingleDfToNestedSeries.time_run
91.8M 93.6M 1.02 benchmarks.NestedFrameQuery.peakmem_run
6.59±0.06ms 6.72±0.07ms 1.02 benchmarks.NestedFrameQuery.time_run
9.55±0.08ms 9.64±0.1ms 1.01 benchmarks.NestedFrameAddNested.time_run
258M 258M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
84.8M 84.6M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
88.5M 88.2M 1.00 benchmarks.NestedFrameReduce.peakmem_run
1.09±0.01ms 1.09±0.01ms 1.00 benchmarks.NestedFrameReduce.time_run
282M 281M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
58.9±3ms 58.0±3ms 0.99 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

@dougbrn dougbrn requested a review from hombit September 23, 2024 18:58
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dougbrn dougbrn merged commit aa34af1 into main Sep 23, 2024
11 checks passed
@dougbrn dougbrn deleted the from_flat_df branch September 23, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedFrame.from_flat doesn't work with pd.DataFrame input
2 participants