Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Adds a
how
argument inadd_nested
to align with a traditional pandas join and in preparation from the change fromadd_nested
tojoin_nested
(see #120)Solution Description
The previous
add_nested
implementation packed the nested frame into a single column which is then assigned to our base layer. Here we simply add this column using a traditional join and then make use of the join'show
argument. Since our previous implementation produces the same results as the "left" argument, I was concerned that replacing the single column assignment with a join might decrease performance. However a preliminary benchmarking shows no notable change.Also of note here is that for the case of
how="right"
, the nature of the packer still means that the result is implicitly using the index of our base layer but now drops values from it that were not present in the index of our "right" nested layer.Code Quality
Project-Specific Pull Request Checklists
New Feature Checklist