Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedFrame.query(None) should return an explicit error #114

Closed
dougbrn opened this issue Jun 25, 2024 · 4 comments
Closed

NestedFrame.query(None) should return an explicit error #114

dougbrn opened this issue Jun 25, 2024 · 4 comments
Assignees
@gitosaurus
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dougbrn
Copy link
Collaborator

dougbrn commented Jun 25, 2024 •
edited
Loading

Providing no input to query should return an explicit value error
@dougbrn dougbrn added the bug Something isn't working label Jun 25, 2024
@dougbrn dougbrn changed the title NestedFrame.query(None) should return an error NestedFrame.query(None) should return an explicit error Jun 26, 2024
@dougbrn
Copy link
Collaborator Author

dougbrn commented Jun 26, 2024

The line df.query(None):
Nested-Pandas returns TypeError: object of type 'NoneType' has no len()
Wheras Pandas returns an explicit error: ValueError: expr must be a string to be evaluated, <class 'NoneType'> given

@hombit hombit added the good first issue Good for newcomers label Jun 27, 2024
@harsha-mangena
Copy link

@dougbrn, Can I pick this issue?

@dougbrn
Copy link
Collaborator Author

dougbrn commented Aug 20, 2024

Feel free, thanks!

@gitosaurus gitosaurus self-assigned this Oct 15, 2024
@gitosaurus
Copy link
Contributor

Resolved as part of #150 . Now NestedFrame.query produces the identical error to DataFrame.query for the same edge conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitosaurus gitosaurus

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hombit @gitosaurus @dougbrn @harsha-mangena