Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by one error in render_stride #3

Closed
NthStarFarer opened this issue Aug 30, 2023 · 1 comment
Closed

Off by one error in render_stride #3

NthStarFarer opened this issue Aug 30, 2023 · 1 comment

Comments

@NthStarFarer
Copy link

The move cursor escape code used in render_stride uses one-indexed values for the row and column, but the values passed are zero indexed. This results in a row and column of pixels and the bottom and right edges of the video to only be set once when the first frame is drawn, since that is the only time a whole frame is normally drawn without moving the cursor. This was likely missed due to both Bad Apple and I wanna be a girl starting on pure black frames, meaning that this only caused a black border.
This also seems to be the cause of at least some of the artifacting I mentioned in #1.

This can be seen as the white border around the bottom and right sides in this video

@lilyyy411
Copy link
Owner

Yep, I noticed this a while ago. I forgot that the terminal's escape sequences were 1-indexed. The next update will fix it because it will use crossterm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants