Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: SK support #87

Merged
merged 2 commits into from
Oct 18, 2024
Merged

add: SK support #87

merged 2 commits into from
Oct 18, 2024

Conversation

michal0000000
Copy link

Added support for SK domains

@michal0000000 michal0000000 mentioned this pull request Oct 14, 2024
@likexian
Copy link
Owner

Hello @michal0000000
Thanks for your works! but the ci is failed.

  Running [/home/runner/golangci-lint-1.61.0-linux-amd64/golangci-lint run --out-format=github-actions -v] in [] ...
  Error: File is not `gofmt`-ed with `-s` (gofmt)
  Error: File is not `gofmt`-ed with `-s` (gofmt)
  Error: ineffectual assignment to token (ineffassign)
  Error: assigned to token, but reassigned without using the value (wastedassign)

If you think this repository is helpful, please share it with friends, thanks.

@michal0000000
Copy link
Author

Thanks for having a look at my PR.
Hopefully I fixed the issue.

@likexian
Copy link
Owner

Hello @michal0000000
Thanks for your works.


If you think this repository is helpful, please share it with friends, thanks.

@likexian likexian merged commit 95f6cb3 into likexian:master Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants