ngDialog is in use by many people. In order to ensure quality and prevent regressions, all contributions require unit tests proving that the contribution:
- Fixes a bug
- Performs new functionality as expected
- Behaves in a predictable manner when misused (bad input given as an option for example)
In addition, where a contribution is aimed at resolving a bug or implementing a feature that can only be measured in a real browser, an e2e test proving the expected behaviour should be included.
If your PR adds new behaviour or modifies existing behaviour, the README should be updated.
All code in any code-base should look like a single person typed it, no matter how many people contributed.
This section describes the coding style guide of the repo. You might not agree with it and that's fine, but if you're going to send PRs, treat this guide as a law.
- indent style is 4 spaces
- always use single quotes
- one space after
if,for,while, etc. - no spaces between
(,)and statement content - use one
varper variable unless you don't assign any values to it (and it's short enough) - always
'use strict'mode - always use strict comparisons:
===and!== - use semicolons
- don't use comma-first notation