[1.0][filter] add ability to configre filters at runtime.

[makasim]

No description provided.

[makasim]

@havvg ping

[makasim]

@havvg ping

[makasim]

@havvg what about this PR?

[havvg]

Hm.. I can't find the issue right now, I remember parts of it, but I'm not 100% sure. What's the use case behind this?

[makasim]

What's the use case behind this?

@havvg see #313

[makasim]

Hm.. I can't find the issue right now, I remember parts of it, but I'm not 100% sure.

I think you are confused it with another PR (#288). this one is a new one

[makasim]

@havvg it is much simpler to configure filters at runtime now. see the doc

[havvg]

But this example replaces the thumbnail filter (or parts of its configuration).
If you actually would do this with variables, the cached images are most probably not of the same filter (with the same configuration).

[makasim]

@havvg no it does not, it just merge configs return array_replace_recursive($this->filters[$filter], $runtimeConfig);

if call $this->filterManager->applyFilter($binary, $filter) next time it will return statically configured option.

[makasim]

@havvg maybe array_replace_recursive has to be moved from FilterConfiguration to FilterManager. I will do that.

[havvg]

I believe I mixed it up with dynamic filters, I can't see any needs for this right now. I need to think about this a bit a more :-)

I was very busy the other days, I want to complete the data remodelling these days, so the injection of filters becomes easier and we got a clean data structure.

[makasim]

I believe I mixed it up with dynamic filters, I can't see any needs for this right now.

my PR about dynamic filters is based on this one. Also dynamic filters were requested several times on issues and even there were attempts to implement it.

If you are agree with interface we can merge it and change implementation later

<?php

$filterManager->filterApply($path, $filter, array $runtimeConfig = array());

[havvg]

I like the idea of dynamic filters and I'm aware this one is a required feature. But the way a filter becomes dynamic should not be modifying a configured one. A dynamic filter isn't configured, but it's injected at runtime.

The filter handling of this bundle should not be aware of any distinction between a configured filter (e.g. via bundles configuration) or a "dynamic" filter which for example is injected into the filter manager using a listener on kernel.request (route options => filter) or an actual runtime filter (user land code actually creating a filter prior using it).

So any changes required to make this happen, which are solely to make it possible to modify (add, re-configure, ..) a filter at runtime, are bad, imho. That's why I started to re-model the data structure, which will open many ways to append filters to the manager (incl. runtime, database backed etc.).

[makasim]

A dynamic filter isn't configured, but it's injected at runtime.

that's how it is done, pre configured filters never modified.

[makasim]

Configs merged at runtime if you pass it, if not pre-configured will be used.

The filter handling of this bundle should not be aware of any distinction between a configured filter (e.g. via bundles configuration) or a "dynamic" filter which for example is injected into the filter manager using a listener on kernel.request (route options => filter) or an actual runtime filter (user land code actually creating a filter prior using it).

Sounds a bit complected do we really need such abstractions?

[makasim]

@havvg moved configs merge logic to FilterManager. Previously it was in FilterConfiguration::get method. Also I introduced a new method FilterManager::apply. It takes binary and config. You can apply filters even without having one configured in config.yml. apllyFilters reuse it.

Use cases:

// pre configured filter
$filterManager->applyFilter($binary, $filter);

// pre configured filter + partially configured at runtime
$filterManager->applyFilter($binary, $filter, array(
    'filters' => array(
        'thumbnail' => array('size' => array(100, 100))
    )
));

// at runtime
$filterManager->apply($binary, array(
    'filters' => array(
        'thumbnail' => array(
            'size' => array(100, 100),
            'mode' => 'outbound',
        )
    )
));

Pre configured filter config does not changed in any given example above

[makasim]

@havvg ping. this is the current approach: #309 (comment)

[makasim]

@havvg ping

[makasim]

closing in favor #313