Enable configuration of post processors using parameters #720
Conversation
|
👍 |
|
👍 Could play interestingly with this - #717 |
|
👍 |
lsmith77
added
the
State: Reviewing
| @@ -31,6 +31,7 @@ | |||
| "symfony/form": "~2.3|~3.0", | |||
| "symfony/console": "~2.3|~3.0", | |||
| "symfony/phpunit-bridge": "~2.3|~3.0", | |||
| "symfony/process": "~2.3|~3.0", | |||
There was a problem hiding this comment.
Post processors use ProcessBuilder class from symfony/process component. Maybe it should be included in composer require section?
There was a problem hiding this comment.
yeah .. should be in the require section
|
needs a rebase .. also a small entry to the docs is needed. sorry for the delay |
|
Separately to this, I wonder if it's worth applying the same default configuration to the other two PostProcessors, and also if it's worth implementing the ConfigurablePostProcessorInterface to these? More flexibility + discouraging maintaining state in the PostProcessor which should help with perf. Happy to raise as an issue if so. |
|
sounds good to me .. |
|
there is overlap with #756 and this PR |
|
Looks like that's been taken care of in that PR, leaving only one item for the to-do list. 😄 @notrix If you haven't the time to write docs atm, I'm happy to write up some docs and PR against your local repo, leaving just the rebase against master before this can be merged - Sound okay? EDIT: Ninja'd! |
|
@antoligy it would be great if you could write some docs. Thnx |
|
Done! notrix#1 |
|
great .. github tells me that there are conflicts that must be resolved. could you rebase on master? |
Fix for invalid variable name Move symfony/process component to require section Adding documentation for new parameters. add @event annotation to let IDEs known event names and class instance Introduce mozjpeg and pngquant post-processors, add transform options, and document. Fix style issues. Move runtime configuration to separate interface using Fix tempnam usages Quote strings starting '%' in YAML Add Flysystem resolver As a counterpart to the flysystem loader, using this resolver it is also possible to store the cached filter-files in flysystem adapters. * add FlysystemResolver * add tests for FlysystemResolver * add documentation for FlysystemResolver * exclude correct `Tests` folder from scrutinizer analysis background filter: allow image positioning allow positioning of the image on the background. uses the same position options as the watermark filter. Implement Imagine Grayscale filter Add phpunit tests for Grayscale filter Change array definition for PHP 5.3 support Add documentation for Grayscale filter Style CI Upgrade Imagine lowest dependency from 0.5 to 0.6.3 for Grayscale filter results purpose next release will be 1.6.0 Applied fixes from StyleCI Downscale filter scales an image to fit bounding box Test for DownscaleFilterLoader PHP 5.3 array style Make StyleCI happy Invalid exif orientation values should be a no op Applied fixes from StyleCI
|
This is madness. I have merged with liip:master branch and got additional commit to this PR. So I rebased and now it shows 31 files modified.. Is it possible to fix this mess? |
|
In this case it might be worth raising a second PR which resolves this one. Ideally after rebasing you'd want to force push to your branch, but it On 21 Jul 2016 8:24 am, "Vaidas" [email protected] wrote:
|
|
@notrix generally you want to rebase feature branches from master instead of merging from master: question is if #756 covers everything in this PR? |
Enable configuration of post processors using parameters (closes #720)
lsmith77
removed
the
State: Reviewing
No description provided.