Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background filter #699

Merged
merged 1 commit into from
Jan 22, 2016
Merged

Fix background filter #699

merged 1 commit into from
Jan 22, 2016

Conversation

jockri
Copy link
Contributor

@jockri jockri commented Jan 22, 2016

This solves #640

@makasim
Copy link
Collaborator

makasim commented Jan 22, 2016

Does it work for you?

@jockri
Copy link
Contributor Author

jockri commented Jan 22, 2016

Yes, before this change I was receiving this error:
Error: Attempted to call method "palette" on class "Imagine\Imagick\Image" in vendor/liip/imagine-bundle/Liip/ImagineBundle/Imagine/Filter/Loader/BackgroundFilterLoader.php at line 22
And now it works again.

@makasim
Copy link
Collaborator

makasim commented Jan 22, 2016

What is the version of imagine library you have?

@jockri
Copy link
Contributor Author

jockri commented Jan 22, 2016 

        "name": "imagine/imagine",
            "version": "v0.5.0",
            "source": {
                "type": "git",
                "url": "https://github.com/avalanche123/Imagine.git",
                "reference": "f64ec666baaa800edcbf237db41121a569230709"
            },

makasim added a commit that referenced this pull request Jan 22, 2016
@makasim
Merge pull request #699 from jockri/fix-background-filter
417a2d5 
Fix background filter
@makasim makasim merged commit 417a2d5 into liip:master Jan 22, 2016
mangelsnc added a commit to mangelsnc/LiipImagineBundle that referenced this pull request Feb 16, 2016
@mangelsnc
Revert "Merge pull request liip#699 from jockri/fix-background-filter"
fdcf396 
This reverts commit 417a2d5, reversing
changes made to 40e98ef.
makasim added a commit that referenced this pull request Feb 16, 2016
@makasim
Merge pull request #709 from mangelsnc/hotfix/unexistent-color-class
3be0322 
Revert "Merge pull request #699 from jockri/fix-background-filter"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jockri @makasim @mangelsnc